Use TypedData APIs exclusively#1003
Conversation
Co-authored-by: Randy Stauner <randy.stauner@shopify.com>
Co-authored-by: Randy Stauner <randy.stauner@shopify.com>
|
I think the clean-up can be done in the end-proc (see #1004). |
|
Thanks, I had left the backends code alone because I had no idea how you're even supposed to wrap that kind of thing, and I guess the answer is you just don't. |
I'd like to second this request, because it seems |
|
nevermind, it seems like I had a corrupted cache. A first attempt a A release definitely would be nice though. |
|
+1 for @nobu's PR and a patch release :) |
#998 updated most of the APIs to use TypedData 🙌. However a few of the legacy uses were still left. This PR converts the remaining two cases.
The legacy API has been removed from Ruby HEAD (likely to be released with Ruby 4.1 in December).
One thing to note is that I don't believe
rb_mShutdownHookworked before this change. When the wrapped struct is NULL the dfree function is skipped.A new release after this is merged would be very appreciated for Ruby HEAD compatibility 🙏
Fixes #1002